[webkit-reviews] review granted: [Bug 230347] box-shadow and text-shadow do not yield float values while interpolating : [Attachment 438681] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 230347: box-shadow and text-shadow do not yield float values while
interpolating
https://bugs.webkit.org/show_bug.cgi?id=230347

Attachment 438681: Patch

https://bugs.webkit.org/attachment.cgi?id=438681&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 438681
  --> https://bugs.webkit.org/attachment.cgi?id=438681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438681&action=review

> Source/WebCore/rendering/TextDecorationPainter.cpp:258
> +	       int shadowX = LayoutUnit(m_isHorizontal ? shadow->x().value() :
shadow->y().value());
> +	       int shadowY = LayoutUnit(m_isHorizontal ? shadow->y().value() :
-shadow->x().value());

These should be floats. Maybe we should even pixel snap them (not necessary for
t his patch).

> Source/WebCore/rendering/TextDecorationPainter.cpp:278
> +	       int shadowX = LayoutUnit(m_isHorizontal ? shadow->x().value() :
shadow->y().value());
> +	       int shadowY = LayoutUnit(m_isHorizontal ? shadow->y().value() :
-shadow->x().value());

Same.