[webkit-reviews] review granted: [Bug 214448] Web Share permission policy "web-share" and "self" as the allowlist : [Attachment 438640] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Marcos Caceres
<marcos at marcosc.com>'s request for review:
Bug 214448: Web Share permission policy "web-share" and "self" as the allowlist
https://bugs.webkit.org/show_bug.cgi?id=214448

Attachment 438640: Patch

https://bugs.webkit.org/attachment.cgi?id=438640&action=review




--- Comment #30 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 438640
  --> https://bugs.webkit.org/attachment.cgi?id=438640
Patch

r=me if canShare implementation is aligning with other browsers and/or ongoing
spec work.

View in context: https://bugs.webkit.org/attachment.cgi?id=438640&action=review

> Source/WebCore/page/Navigator.cpp:134
> +	   return false;

I am unsure whether we actually want that check.
https://w3c.github.io/web-share/#canshare-data-method does not mention this
check. Is the idea to update the spec?
What are doing other browsers?