[webkit-reviews] review granted: [Bug 230445] Remove use of NSScrollAnimationHelper for animated scrolls : [Attachment 438565] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 18 12:23:26 PDT 2021

Martin Robinson <mrobinson at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 230445: Remove use of NSScrollAnimationHelper for animated scrolls

Attachment 438565: Patch


--- Comment #2 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 438565
  --> https://bugs.webkit.org/attachment.cgi?id=438565

View in context: https://bugs.webkit.org/attachment.cgi?id=438565&action=review

This is a great cleanup!

> Source/WebCore/platform/ScrollAnimator.cpp:109
> +    WTFLogAlways("scrollToPositionWithoutAnimation to %.2f",

Are these WTFLogAlways calls left over or did you mean to add them?

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:54
>  static bool scrollAnimationEnabledForSystem()

I think this can be removed and moved into the body of
platformAllowsScrollAnimation. I don't think it's used anywhere else.

More information about the webkit-reviews mailing list