[webkit-reviews] review granted: [Bug 229702] Add support for CSSUnparsedValue parsing and reification of various CSSValue : [Attachment 438520] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted  review:
Bug 229702: Add support for CSSUnparsedValue parsing and reification of various
CSSValue
https://bugs.webkit.org/show_bug.cgi?id=229702

Attachment 438520: Patch

https://bugs.webkit.org/attachment.cgi?id=438520&action=review




--- Comment #30 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 438520
  --> https://bugs.webkit.org/attachment.cgi?id=438520
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438520&action=review

> Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:65
> +

extra spaces

> Source/WebCore/css/typedom/StylePropertyMapReadOnly.cpp:51
> +    return (result.hasException() ? nullptr : RefPtr<CSSStyleValue> {
result.releaseReturnValue() });

I wonder if we'll want to return ExceptionOr<RefPtr> here to pass the exact
exception up the call stack.

>
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertym
ap/inline/get.html:35
> +  // assert_style_value_equals(styleMap.get('--foo'),

This should probably be removed.