[webkit-reviews] review granted: [Bug 230431] RenderListMarker::imageChanged RenderBox image handling : [Attachment 438528] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 230431: RenderListMarker::imageChanged RenderBox image handling
https://bugs.webkit.org/show_bug.cgi?id=230431

Attachment 438528: Patch

https://bugs.webkit.org/attachment.cgi?id=438528&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 438528
  --> https://bugs.webkit.org/attachment.cgi?id=438528
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438528&action=review

> Source/WebCore/ChangeLog:9
> +	   No new tests (OOPS!).

Why no tests? Seems like we can and should make a test for whatever problem
this caused.

> Source/WebCore/rendering/RenderListMarker.cpp:1803
> +    if (m_image) {
> +	   if (o == m_image->data()) {

Let’s not nest this so much:

    if (m_image && o == m_image->data()) {
	...