[webkit-reviews] review granted: [Bug 230430] [ macOS Release ] TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery is flaky timing out : [Attachment 438535] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 230430: [ macOS Release ]
TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=230430

Attachment 438535: Patch

https://bugs.webkit.org/attachment.cgi?id=438535&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 438535
  --> https://bugs.webkit.org/attachment.cgi?id=438535
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438535&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:228
> +    TestWebKitAPI::Util::run(&finishedRunningScript);

TestWKWebView has objectByEvaluatingJavaScript which does this.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:241
> +    } while (!canSecondWebViewSeeNewCookie);

It should only take one try.