[webkit-reviews] review granted: [Bug 230284] Addition of CSSTransformValue, CSSTransformComponent & subclasses : [Attachment 438515] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted  review:
Bug 230284: Addition of CSSTransformValue, CSSTransformComponent & subclasses
https://bugs.webkit.org/show_bug.cgi?id=230284

Attachment 438515: Patch

https://bugs.webkit.org/attachment.cgi?id=438515&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 438515
  --> https://bugs.webkit.org/attachment.cgi?id=438515
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438515&action=review

> Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp:33
> +

nit: extra space

> Source/WebCore/css/typedom/transform/CSSTransformComponent.h:61
> +

nit: extra space.

> Source/WebCore/css/typedom/transform/CSSTransformComponent.h:63
> +    bool m_is2D;

This is uninitialized memory.  I'll add { false } while landing.

> Source/WebCore/css/typedom/transform/CSSTransformValue.h:56
> +    bool m_is2D;

ditto