[webkit-reviews] review granted: [Bug 229727] imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-load-var.html crashes : [Attachment 438346] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 17 15:29:47 PDT 2021


Darin Adler <darin at apple.com> has granted Chris Lord <clord at igalia.com>'s
request for review:
Bug 229727:
imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-load-var.html
crashes
https://bugs.webkit.org/show_bug.cgi?id=229727

Attachment 438346: Patch

https://bugs.webkit.org/attachment.cgi?id=438346&action=review




--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 438346
  --> https://bugs.webkit.org/attachment.cgi?id=438346
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438346&action=review

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:223
> +    const CSSParserToken& token = range.peek();

Consider auto&?

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:370
> +    const CSSParserToken& token = sourceRange.peek();

Ditto.


More information about the webkit-reviews mailing list