[webkit-reviews] review granted: [Bug 230393] [JSC] Add fast property enumeration mode for JSON.stringify : [Attachment 438504] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 230393: [JSC] Add fast property enumeration mode for JSON.stringify
https://bugs.webkit.org/show_bug.cgi?id=230393

Attachment 438504: Patch

https://bugs.webkit.org/attachment.cgi?id=438504&action=review




--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 438504
  --> https://bugs.webkit.org/attachment.cgi?id=438504
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438504&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   This patch adds fast object property enumeration. When we know that
source object has some conditions, we can say that,

I suggest "has some conditions" ==> "meets some conditions".

> Source/JavaScriptCore/runtime/JSONObject.cpp:96
> +	   bool isFastObjectProperties() const { return
m_isFastObjectProperties; }

nit: let's rename these to `hasFastObjectProperties()` and
`m_hasFastObjectProperties`.