[webkit-reviews] review granted: [Bug 230384] Add MIME type and URL to WebCore::Model to allow processing different model types : [Attachment 438436] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 230384: Add MIME type and URL to WebCore::Model to allow processing
different model types
https://bugs.webkit.org/show_bug.cgi?id=230384

Attachment 438436: Patch

https://bugs.webkit.org/attachment.cgi?id=438436&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 438436
  --> https://bugs.webkit.org/attachment.cgi?id=438436
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438436&action=review

> Source/WebCore/platform/graphics/Model.h:33
>  #include <wtf/RefCounted.h>
> +#include <wtf/URL.h>
> +#include <wtf/text/WTFString.h>

You can just include URL.h, don’t need the other two.

> Source/WebCore/platform/graphics/Model.h:43
> +    WEBCORE_EXPORT static Ref<Model> create(Ref<SharedBuffer>, String, URL);

Bold trailblazing to use String for a string that we are adopting, as opposed
to the more obvious String&& and old school const String&. Does seem simpler
than String&& with no obvious disadvantage except for being less explicit.