[webkit-reviews] review granted: [Bug 230398] [LFC][Integration] Add some useful functions to iterators : [Attachment 438462] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 230398: [LFC][Integration] Add some useful functions to iterators
https://bugs.webkit.org/show_bug.cgi?id=230398

Attachment 438462: Patch

https://bugs.webkit.org/attachment.cgi?id=438462&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 438462
  --> https://bugs.webkit.org/attachment.cgi?id=438462
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438462&action=review

>
Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h:138
> +    enum class HyphenMode { Include, Ignore };
> +    TextRun createTextRun(HyphenMode hyphenMode = HyphenMode::Include) const

How does the caller decide whether it needs hyphen or not (as this decision is
mostly driven by line breaking and the run already includes it In
::renderedContent())