[webkit-reviews] review granted: [Bug 230357] Improve access case printing and show inline capacity for structures : [Attachment 438416] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 230357: Improve access case printing and show inline capacity for
structures
https://bugs.webkit.org/show_bug.cgi?id=230357

Attachment 438416: Patch

https://bugs.webkit.org/attachment.cgi?id=438416&action=review




--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 438416
  --> https://bugs.webkit.org/attachment.cgi?id=438416
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438416&action=review

> Source/JavaScriptCore/runtime/Structure.cpp:1327
> +	   "/", (uint32_t)(reinterpret_cast<uintptr_t>(sid)), ", ",

I feel like "(uint32_t)(reinterpret_cast<uintptr_t>(sid))" can just be "id()"
:-) 

I think that reinterpret_cast is just there to print as hex? Which is kinda
silly. We should eventually just make a hex printer that doesn't require a
pointer.

Also, do we really need to print the structure id int both as hex and as base
10?