[webkit-reviews] review granted: [Bug 230363] Fix TestWebKitAPI.WebKit.AppHighlightsInImageOverlays to work with changing menu states. : [Attachment 438370] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 230363: Fix TestWebKitAPI.WebKit.AppHighlightsInImageOverlays to work with
changing menu states.
https://bugs.webkit.org/show_bug.cgi?id=230363

Attachment 438370: Patch

https://bugs.webkit.org/attachment.cgi?id=438370&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 438370
  --> https://bugs.webkit.org/attachment.cgi?id=438370
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438370&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:101
> +    EXPECT_EQ([contentView
targetForAction:createHighlightForCurrentQuickNoteWithRangeSelector
withSender:nil], nil);

Maybe `EXPECT_NULL` to match the ones above? But this works too.