[webkit-reviews] review granted: [Bug 228089] [ MacOS & iOS & GTK ] imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html is flaky failing : [Attachment 438286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 15 17:13:40 PDT 2021

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 228089: [ MacOS & iOS & GTK ]
a-elements/htmlanchorelement_noopener.html is flaky failing

Attachment 438286: Patch


--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 438286
  --> https://bugs.webkit.org/attachment.cgi?id=438286

View in context: https://bugs.webkit.org/attachment.cgi?id=438286&action=review

> Source/WebCore/page/DOMWindow.cpp:1062
> +	       page->chrome().closeWindowSoon();

Is the "soon" still needed? Seems like the queued task is now taking care of
the scheduling. Can we clean up further by just doing closeWindow; at some

More information about the webkit-reviews mailing list