[webkit-reviews] review granted: [Bug 229897] Implement exp, log functions calc functions : [Attachment 438280] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 15 16:53:00 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 229897: Implement exp,log functions calc functions
https://bugs.webkit.org/show_bug.cgi?id=229897

Attachment 438280: Patch

https://bugs.webkit.org/attachment.cgi?id=438280&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 438280
  --> https://bugs.webkit.org/attachment.cgi?id=438280
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438280&action=review

> Source/WebCore/ChangeLog:7
> +	   Reviewed by NOBODY (OOPS!).
> +

You should write some words here about the change.

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:-441
> -	   return;

Is this removal significant? The changelog does not mention it.


More information about the webkit-reviews mailing list