[webkit-reviews] review granted: [Bug 230298] [JSC] Optimize leaf object creation in JSON.parse : [Attachment 438266] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 230298: [JSC] Optimize leaf object creation in JSON.parse
https://bugs.webkit.org/show_bug.cgi?id=230298

Attachment 438266: Patch

https://bugs.webkit.org/attachment.cgi?id=438266&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 438266
  --> https://bugs.webkit.org/attachment.cgi?id=438266
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438266&action=review

r=me

> Source/JavaScriptCore/runtime/LiteralParser.cpp:1413
> +	       case TokRBracket:
> +		   m_parseErrorMessage = "Unexpected token ']'"_s;
> +		   return { };

It seems like a lot of the error messages are the same whenever we create an
error message for that token. Should we just make a helper,
`setErrorMessageForToken` that sets the m_parseErrorMessage when we error on a
given token?