[webkit-reviews] review denied: [Bug 229710] [WASM-Function-References] Add call_ref spec tests : [Attachment 437493] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 15 00:44:47 PDT 2021

Yusuke Suzuki <ysuzuki at apple.com> has denied Dmitry <dbezhetskov at igalia.com>'s
request for review:
Bug 229710: [WASM-Function-References] Add call_ref spec tests

Attachment 437493: Patch


--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 437493
  --> https://bugs.webkit.org/attachment.cgi?id=437493

View in context: https://bugs.webkit.org/attachment.cgi?id=437493&action=review

> Source/JavaScriptCore/ChangeLog:9
> +	   Removed redundand TypeKind::TypeIdx because new Ref and RefNull
opcodes cover all
> +	   the same cases.

I have several questions. So can you answer to these questions? And can you
describe the changelog to answer these questions?

1. "if TypedFunctionReferences are enabled then Externref and FunctionRef are
represented as nullable references with corresponding indices". But I saw
Wasm::Types::Funcref and Wasm::Types::Externref use in
wasm/js/WebAssemblyGlobalConstructor.cpp, Table::wasmType, and
TableInformation::wasmType. Can you explain why it is correct?
2. I saw several places are not having TypeKind::TypeIdx / TypeKind::Ref /
TypeKind::RefNull. For example, BytecodeDumper::formatConstant has
TypeKind::Externref and TypeKind::Funcref clauses, but it does not have Ref /
RefNull etc. Can you explain why this is correct?

Also, can you add tests covering the above cases?

More information about the webkit-reviews mailing list