[webkit-reviews] review granted: [Bug 230295] Move scrollbar-related code out of ScrollAnimator and into ScrollbarsController : [Attachment 438215] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 230295: Move scrollbar-related code out of ScrollAnimator and into
ScrollbarsController
https://bugs.webkit.org/show_bug.cgi?id=230295

Attachment 438215: Patch

https://bugs.webkit.org/attachment.cgi?id=438215&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 438215
  --> https://bugs.webkit.org/attachment.cgi?id=438215
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438215&action=review

Best make it build.

> Source/WebCore/Sources.txt:1821
> +platform/ScrollbarsController.cpp

I am vaguely surprised about the plural.

> Source/WebCore/platform/mac/ScrollbarsControllerMac.mm:197
> +    RetainPtr<NSTimer> _timer;

Cocoa timer instead of ours is kind of surprising, though I suppose not a
problem and not new?