[webkit-reviews] review denied: [Bug 229116] WebKit might load custom URI scheme request content multiple times : [Attachment 438183] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 229116: WebKit might load custom URI scheme request content multiple times
https://bugs.webkit.org/show_bug.cgi?id=229116

Attachment 438183: Patch

https://bugs.webkit.org/attachment.cgi?id=438183&action=review




--- Comment #24 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 438183
  --> https://bugs.webkit.org/attachment.cgi?id=438183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438183&action=review

I really think the strong typing needs to be done before this.	It's hard to
see whether this is correct or not.

> Source/WebKit/UIProcess/WebURLSchemeHandler.cpp:113
> +    for (auto& t : m_tasks.values()) {
> +	   if (t->webProcessTaskID() == webProcessTaskIdentifier) {

This isn't good.  The whole point of a HashMap is so that we don't have to look
at all the values.  This takes a O(1) algorithm and makes it an O(n) algorithm.