[webkit-reviews] review granted: [Bug 203312] Implement the CSS exponent functions: pow(), sqrt(), hypot() : [Attachment 438097] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kevin Turner
<kevinturner at utexas.edu>'s request for review:
Bug 203312: Implement the CSS exponent functions: pow(), sqrt(), hypot()
https://bugs.webkit.org/show_bug.cgi?id=203312

Attachment 438097: Patch

https://bugs.webkit.org/attachment.cgi?id=438097&action=review




--- Comment #50 from Darin Adler <darin at apple.com> ---
Comment on attachment 438097
  --> https://bugs.webkit.org/attachment.cgi?id=438097
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438097&action=review

> Source/WebCore/platform/calc/CalcExpressionOperation.cpp:102
> +	   if (value < 0)
> +	       return std::numeric_limits<float>::quiet_NaN();

This isn’t needed, since std::sqrt already does this when passed a negative
number.