[webkit-reviews] review granted: [Bug 230279] Rename RESOURCE_LOAD_STATISTICS to INTELLIGENT_TRACKING_PREVENTION : [Attachment 438181] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 230279: Rename RESOURCE_LOAD_STATISTICS to INTELLIGENT_TRACKING_PREVENTION
https://bugs.webkit.org/show_bug.cgi?id=230279

Attachment 438181: Patch

https://bugs.webkit.org/attachment.cgi?id=438181&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 438181
  --> https://bugs.webkit.org/attachment.cgi?id=438181
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438181&action=review

> Source/cmake/OptionsFTW.cmake:151
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_POINTER_LOCK PRIVATE OFF)
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE
OFF)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION
PRIVATE OFF)
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE OFF)

Looks like this was sorted alphabetically before. Should move it.

> Source/cmake/OptionsGTK.cmake:170
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_POINTER_LOCK PRIVATE ON)
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ON)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION
PRIVATE ON)
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ON)

Looks like this was sorted alphabetically before. Should move it.

> Source/cmake/OptionsMac.cmake:76
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESIZE_OBSERVER PRIVATE ON)
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ON)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION
PRIVATE ON)
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE ON)

Looks like this was sorted alphabetically before. Should move it.

> Source/cmake/OptionsWPE.cmake:65
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PERIODIC_MEMORY_MONITOR PRIVATE ON)
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE ON)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION
PRIVATE ON)
>  WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE ON)

Looks like this was sorted alphabetically before. Should move it.

> Source/cmake/OptionsWin.cmake:83
>      WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE
${ENABLE_EXPERIMENTAL_FEATURES})
> -    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_LOAD_STATISTICS PRIVATE
${ENABLE_EXPERIMENTAL_FEATURES})
> +    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTELLIGENT_TRACKING_PREVENTION
PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
>      WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_RESOURCE_USAGE PRIVATE
${ENABLE_EXPERIMENTAL_FEATURES})

Looks like this was sorted alphabetically before. Should move it.

> Source/cmake/WebKitFeatures.cmake:201
>      WEBKIT_OPTION_DEFINE(ENABLE_RESIZE_OBSERVER "Toggle Resize Observer
support" PRIVATE ON)
> -    WEBKIT_OPTION_DEFINE(ENABLE_RESOURCE_LOAD_STATISTICS "Toggle resource
load statistics support" PRIVATE OFF)
> +    WEBKIT_OPTION_DEFINE(ENABLE_INTELLIGENT_TRACKING_PREVENTION "Toggle
resource load statistics support" PRIVATE OFF)
>      WEBKIT_OPTION_DEFINE(ENABLE_RESOURCE_USAGE "Toggle resource usage
support" PRIVATE OFF)

Looks like this was sorted alphabetically before. Should move it.