[webkit-reviews] review granted: [Bug 230273] CSSFontFaceSrcValue.cssText should be quoted consistently with other browsers : [Attachment 438165] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 230273: CSSFontFaceSrcValue.cssText should be quoted consistently with
other browsers
https://bugs.webkit.org/show_bug.cgi?id=230273

Attachment 438165: Patch

https://bugs.webkit.org/attachment.cgi?id=438165&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 438165
  --> https://bugs.webkit.org/attachment.cgi?id=438165
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438165&action=review

> Source/WebCore/ChangeLog:11
> +	   In a src: line like "src: local(foobar)", Firefox and Chrome will
both quote
> +	   "foobar" when reading out of the OM. Same thing with "src:
url(foobar)".
> +	   We should match them.

Should we add tests cases for format strings that have unusual characters in
them, like a double quote mark?

Exotic, but we are not attempting to correctly handle such cases it seems.