[webkit-reviews] review granted: [Bug 230275] [WinCairo] Add missing include for testapi : [Attachment 438163] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 14 13:52:54 PDT 2021
Don Olmstead <don.olmstead at sony.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 230275: [WinCairo] Add missing include for testapi
https://bugs.webkit.org/show_bug.cgi?id=230275
Attachment 438163: Patch
https://bugs.webkit.org/attachment.cgi?id=438163&action=review
--- Comment #2 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 438163
--> https://bugs.webkit.org/attachment.cgi?id=438163
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=438163&action=review
r=me with nits.
> Source/JavaScriptCore/ChangeLog:3
> + [WinCairo] Add missing include for testapi
I would have this be [Win] JSRemoteInspector.h missing stdint include
At one point we found it with testapi but the actual reason is were missing a
definition for uint8_t when including JSRemoteInspector.h on its own.
> Source/JavaScriptCore/ChangeLog:7
> +
Reason is basically "Include stdint for uint8_t definition on Windows"
More information about the webkit-reviews
mailing list