[webkit-reviews] review granted: [Bug 230145] Linear gradient sometimes is drawn incorrectly and sometimes hangs : [Attachment 438012] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 230145: Linear gradient sometimes is drawn incorrectly and sometimes hangs
https://bugs.webkit.org/show_bug.cgi?id=230145

Attachment 438012: Patch

https://bugs.webkit.org/attachment.cgi?id=438012&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 438012
  --> https://bugs.webkit.org/attachment.cgi?id=438012
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438012&action=review

> Source/WebCore/platform/graphics/cg/GradientCG.cpp:154
> +		       return CGRectGetMaxX(boundingBox) <= std::min(start,
end);

For symmetry I would write this as `return std::min(start, end) >
CGRectGetMaxX(boundingBox)`