[webkit-reviews] review granted: [Bug 230243] URLs in CSS variables must be resolved against the base URL of the stylesheet, not the document : [Attachment 438154] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 14 12:15:04 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 230243: URLs in CSS variables must be resolved against the base URL of the
stylesheet, not the document
https://bugs.webkit.org/show_bug.cgi?id=230243

Attachment 438154: Patch

https://bugs.webkit.org/attachment.cgi?id=438154&action=review




--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 438154
  --> https://bugs.webkit.org/attachment.cgi?id=438154
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438154&action=review

> LayoutTests/ChangeLog:10
> +	   *
fast/css/variables/support/styles/url-with-variable-is-sheet-relative.css:
Added 10 more test cases.
> +	   *
fast/css/variables/url-with-variable-is-sheet-relative-expected.html: Ditto.
> +	   * fast/css/variables/url-with-variable-is-sheet-relative.html:
Ditto.

Would be nice to get these to WPT.


More information about the webkit-reviews mailing list