[webkit-reviews] review granted: [Bug 229944] Use event queue to fire RTCPeerConnection events : [Attachment 438142] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 14 08:36:46 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 229944: Use event queue to fire RTCPeerConnection events
https://bugs.webkit.org/show_bug.cgi?id=229944

Attachment 438142: Patch

https://bugs.webkit.org/attachment.cgi?id=438142&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 438142
  --> https://bugs.webkit.org/attachment.cgi?id=438142
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438142&action=review

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:235
> +	      
m_peerConnection.dispatchEvent(RTCTrackEvent::create(eventNames().trackEvent,
Event::CanBubble::No, Event::IsCancelable::No, WTFMove(event.receiver),
WTFMove(event.track), WTFMove(event.streams), WTFMove(event.transceiver)));

Why are some events dispatched synchronously instead of on the task queue?


More information about the webkit-reviews mailing list