[webkit-reviews] review denied: [Bug 230241] Fix crash in 32 bits due to not enough scratch registers available : [Attachment 438093] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 14 06:24:35 PDT 2021


Caio Lima <ticaiolima at gmail.com> has denied Mikhail R. Gadelha
<mikhail at igalia.com>'s request for review:
Bug 230241: Fix crash in 32 bits due to not enough scratch registers available
https://bugs.webkit.org/show_bug.cgi?id=230241

Attachment 438093: Patch

https://bugs.webkit.org/attachment.cgi?id=438093&action=review




--- Comment #5 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 438093
  --> https://bugs.webkit.org/attachment.cgi?id=438093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438093&action=review

> Source/JavaScriptCore/bytecode/AccessCase.cpp:2327
> +		   slowPath.append(jit.jump());

I’m not comfortable with this generating a bunch of IC code for checks and
other things to always jump to slow path. This seems quite suboptimal. Isn’t
there a way were we skip a case if we figure out we don’t have enough registers
for it? Skipping such case will result in always taking the slow path as well,
but we don’t emit any unnecessary code for it.


More information about the webkit-reviews mailing list