[webkit-reviews] review granted: [Bug 229378] Shadertoy "truchet district" fails to compile with error: Internal error compiling shader with Metal backend" : [Attachment 438030] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted  review:
Bug 229378: Shadertoy "truchet district" fails to compile with error: Internal
error compiling shader with Metal backend"
https://bugs.webkit.org/show_bug.cgi?id=229378

Attachment 438030: Patch

https://bugs.webkit.org/attachment.cgi?id=438030&action=review




--- Comment #17 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 438030
  --> https://bugs.webkit.org/attachment.cgi?id=438030
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438030&action=review

Once this is passing tests, looks good to me. A couple of small
questions/comments. r+

> Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect.cpp:71
> +constexpr Name kFlippedFragCoordName("flippedFragCoord",
SymbolType::BuiltIn);

Curious why these two synthetic names use BuiltIn rather than AngleInternal.

>
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:26
> +	   // The length of a string defined as a char array is the size of the
array minus 1 (the

The indentation looks strange here.

>
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_glslang_mtl_utils.mm:26
4
> +			  << "ANGLE_vertexOut." << kUserDefinedNamePrefix <<
varying.name;

Would it be possible to match the reflow of the earlier code to make the single
kUserDefinedNamePrefix addition more clear?

>
LayoutTests/webgl/pending/resources/webgl_test_files/conformance/glsl/misc/shad
er-with-reserved-words-2.html:4
> +** Copyright (c) 2012 The Khronos Group Inc.

2021

The copyright block was shortened recently. Could you take the one from a newer
test?