[webkit-reviews] review granted: [Bug 230219] Refactor WritableStream to better integrate https://streams.spec.whatwg.org/#create-writable-stream : [Attachment 438041] Patch

[bugzilla-daemon at webkit.org]

Sihui Liu <sihui_liu at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 230219: Refactor WritableStream to better integrate
https://streams.spec.whatwg.org/#create-writable-stream
https://bugs.webkit.org/show_bug.cgi?id=230219

Attachment 438041: Patch

https://bugs.webkit.org/attachment.cgi?id=438041&action=review




--- Comment #3 from Sihui Liu <sihui_liu at apple.com> ---
Comment on attachment 438041
  --> https://bugs.webkit.org/attachment.cgi?id=438041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438041&action=review

r=me, if all bots are green

> Source/WebCore/ChangeLog:9
> +	   we were still going through the WritableStream constructor taking an
underlying source.

underlying sink?

> Source/WebCore/Modules/streams/WritableStreamInternals.js:51
> +    const internalStream = { };

Do we want to Assert: ! IsNonNegativeNumber(highWaterMark) is true as spec?