[webkit-reviews] review granted: [Bug 230191] Add unit test that uses PCM daemon : [Attachment 438057] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 230191: Add unit test that uses PCM daemon
https://bugs.webkit.org/show_bug.cgi?id=230191

Attachment 438057: Patch

https://bugs.webkit.org/attachment.cgi?id=438057&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 438057
  --> https://bugs.webkit.org/attachment.cgi?id=438057
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438057&action=review

>
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementCon
nection.h:45
> +    Connection(CString&& machServiceName);

explicit

>
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementCon
nection.h:53
> +    const CString m_machServiceName;

Would be nice to have a blank line to separate data members from member
functions.

>
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementMan
agerProxy.cpp:75
> +    : m_connection(machServiceName.utf8()) { }

Don't we usually put the { } on the next line?