[webkit-reviews] review granted: [Bug 229543] [JSC] ASSERT failed in stress/for-in-tests.js (32bit) : [Attachment 438060] v6

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 229543: [JSC] ASSERT failed in stress/for-in-tests.js (32bit)
https://bugs.webkit.org/show_bug.cgi?id=229543

Attachment 438060: v6

https://bugs.webkit.org/attachment.cgi?id=438060&action=review




--- Comment #17 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 438060
  --> https://bugs.webkit.org/attachment.cgi?id=438060
v6

View in context: https://bugs.webkit.org/attachment.cgi?id=438060&action=review

r=me with nits.

> Source/JavaScriptCore/dfg/DFGOperations.cpp:2550
> +    JSValue base = JSValue(baseCell);
> +    RETURN_IF_EXCEPTION(scope, { });
> +

This is not necessary. You can just pass JSCell* baseCell to
CommonSlowPaths::opEnumeratorGetByVal

> Source/JavaScriptCore/dfg/DFGOperations.cpp:2552
> +    RETURN_IF_EXCEPTION(scope, { });

This is not necessary since JSValue::decode never throws an error.