[webkit-reviews] review granted: [Bug 230208] REGRESSION(r282278): ASSERTION FAILED: !m_needExceptionCheck in JSC::VM::verifyExceptionCheckNeedIsSatisfied : [Attachment 438019] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 230208: REGRESSION(r282278): ASSERTION FAILED: !m_needExceptionCheck in
JSC::VM::verifyExceptionCheckNeedIsSatisfied
https://bugs.webkit.org/show_bug.cgi?id=230208

Attachment 438019: Patch

https://bugs.webkit.org/attachment.cgi?id=438019&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 438019
  --> https://bugs.webkit.org/attachment.cgi?id=438019
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438019&action=review

> Source/WebCore/bindings/js/InternalWritableStream.cpp:47
>      auto result = call(&globalObject, function, callData,
JSC::jsUndefined(), arguments);

Can we also change the if(UNLIKELY(...) return Exception... 
with:
    RETURN_IF_EXCEPTION(scope, Exception { ExistingExceptionError });

This is more inline with other parts of the codebase.