[webkit-reviews] review granted: [Bug 230187] [Cocoa] Drawing the rounded system ui font into canvas causes a crash : [Attachment 437975] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 230187: [Cocoa] Drawing the rounded system ui font into canvas causes a
crash
https://bugs.webkit.org/show_bug.cgi?id=230187

Attachment 437975: Patch

https://bugs.webkit.org/attachment.cgi?id=437975&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 437975
  --> https://bugs.webkit.org/attachment.cgi?id=437975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437975&action=review

> Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:517
>      if (!fontDescriptor)
>	   return nullptr;

What do you think about using `CTFontDescriptorCreateLastResort()` here as a
sort of failsafe (perhaps with an `ASSERT_NOT_REACHED` so that we're still able
to catch instances where we would've otherwise failed to decode)?