[webkit-reviews] review requested: [Bug 204276] Implement the 'ic' unit from CSS Values 4 : [Attachment 437944] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 11 01:16:51 PDT 2021

Kiet Ho <tho22 at apple.com> has asked  for review:
Bug 204276: Implement the 'ic' unit from CSS Values 4

Attachment 437944: Patch


--- Comment #14 from Kiet Ho <tho22 at apple.com> ---
Created attachment 437944

  --> https://bugs.webkit.org/attachment.cgi?id=437944&action=review


1. I think I'll need more guidance on what to do regarding
DeprecatedCSSOMPrimitive Value
2. Font::platformGlyphInit() requires both the glyph number and width of the
space character, therefore even if there's a method to get the glyph number
then width, we'd have to duplicate the logic to get the glyph number
regardless. I decided to just clean up the method and surrounding areas.

More information about the webkit-reviews mailing list