[webkit-reviews] review granted: [Bug 203312] Implement the CSS exponent functions: pow(), sqrt(), hypot() : [Attachment 437900] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kevin Turner
<kevinturner at utexas.edu>'s request for review:
Bug 203312: Implement the CSS exponent functions: pow(), sqrt(), hypot()
https://bugs.webkit.org/show_bug.cgi?id=203312

Attachment 437900: Patch

https://bugs.webkit.org/attachment.cgi?id=437900&action=review




--- Comment #46 from Darin Adler <darin at apple.com> ---
Comment on attachment 437900
  --> https://bugs.webkit.org/attachment.cgi?id=437900
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437900&action=review

> Source/WebCore/css/calc/CSSCalcExpressionNodeParser.cpp:198
> +    // FIXME: implement asin, acos, atan, atan2.

Could put this FIXME after all the cases (as it was before) instead of in the
middle of the cases (as it is now).

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:1100
> +	   if (value < 0)
> +	       return std::numeric_limits<double>::quiet_NaN();

This isn’t needed, since std::sqrt already does this when passed a negative
number.