[webkit-reviews] review granted: [Bug 230153] Web Inspector: Update naming of WI.CSSCompletions callback used for collecting supported CSS properties from the target : [Attachment 437875] Patch 1.0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 10 16:12:49 PDT 2021


Devin Rousso <drousso at apple.com> has granted Razvan Caliman
<rcaliman at apple.com>'s request for review:
Bug 230153: Web Inspector: Update naming of WI.CSSCompletions callback used for
collecting supported CSS properties from the target
https://bugs.webkit.org/show_bug.cgi?id=230153

Attachment 437875: Patch 1.0

https://bugs.webkit.org/attachment.cgi?id=437875&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 437875
  --> https://bugs.webkit.org/attachment.cgi?id=437875
Patch 1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=437875&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:88
> +	   function propertiesCallback(error, properties)

NIT: this should really be named `cssProperties` to match what's used in the
protocol


More information about the webkit-reviews mailing list