[webkit-reviews] review granted: [Bug 230159] Send preference updates to the GPU Process : [Attachment 437891] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 230159: Send preference updates to the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=230159

Attachment 437891: Patch

https://bugs.webkit.org/attachment.cgi?id=437891&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 437891
  --> https://bugs.webkit.org/attachment.cgi?id=437891
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437891&action=review

r=me

> Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:134
> +id AuxiliaryProcess::decodePreferenceValue(const std::optional<String>&
encodedValue)

Oh, nice! We have centralized this now.

> Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:143
> +    auto classes = [NSSet setWithArray:@[[NSString class], [NSNumber class],
[NSDate class], [NSDictionary class], [NSArray class], [NSData class]]];

I wonder if there is any perf benefit to making this a "NeverDestroyed" thing,
since we presumably construct this set every time we try to decode preference
values.