[webkit-reviews] review granted: [Bug 230155] Factor more text painting functions to TextBoxPainter : [Attachment 437882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 10 09:54:06 PDT 2021


zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 230155: Factor more text painting functions to TextBoxPainter
https://bugs.webkit.org/show_bug.cgi?id=230155

Attachment 437882: Patch

https://bugs.webkit.org/attachment.cgi?id=437882&action=review




--- Comment #3 from zalan <zalan at apple.com> ---
Comment on attachment 437882
  --> https://bugs.webkit.org/attachment.cgi?id=437882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437882&action=review

> Source/WebCore/rendering/TextBoxPainter.cpp:368
> +    auto y = ascent + 0.11035 * fontSize;
> +    auto height = 0.13247 * fontSize;

science.


More information about the webkit-reviews mailing list