[webkit-reviews] review denied: [Bug 229116] WebKit might load custom URI scheme request content multiple times : [Attachment 437825] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 229116: WebKit might load custom URI scheme request content multiple times
https://bugs.webkit.org/show_bug.cgi?id=229116

Attachment 437825: Patch

https://bugs.webkit.org/attachment.cgi?id=437825&action=review




--- Comment #14 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 437825
  --> https://bugs.webkit.org/attachment.cgi?id=437825
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437825&action=review

I looked into whether this problem affects WKWebView and it doesn't seem that
it does because in WKWebView._initializeWithConfiguration we create a
WebURLSchemeHandlerCocoa for each WKWebView and for each scheme.  You might
consider doing something similar in webkit_web_context_register_uri_scheme to
fix this instead to make the ports more similar instead of adding code only
needed by one port in common port-agnostic code.

> Source/WebKit/UIProcess/WebURLSchemeTask.h:105
>      uint64_t m_identifier;
> +    uint64_t m_webProcessTaskIdentifier;

We want to use strongly typed identifiers instead of expanding the use of
uint64_t.  See PageIdentifier.h et al.