[webkit-reviews] review granted: [Bug 230134] Fix some lldb data provider issues : [Attachment 437805] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 230134: Fix some lldb data provider issues
https://bugs.webkit.org/show_bug.cgi?id=230134

Attachment 437805: Patch

https://bugs.webkit.org/attachment.cgi?id=437805&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 437805
  --> https://bugs.webkit.org/attachment.cgi?id=437805
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437805&action=review

Patch looks good.

> Tools/lldb/lldbWebKitTester/main.cpp:33
> +#include <wtf/URL.h>

Ok as is. Thoughts on putting this in sorted order?

> Tools/lldb/lldb_webkit.py:487
> +    def _is_outOfLine(self, rgba_and_flags):

Ok as is. How about using snake casing for consistency?

> Tools/lldb/lldb_webkit.py:509
> +	   out_of_line_components =
self.valobj.CreateValueFromAddress('out_of_line_components', rgba_and_flags &
self.COLOR_VALUE_MASK, out_of_line_components_type)

I didn't know there was such a convenience API for this. Nice.