[webkit-reviews] review granted: [Bug 230129] Add wpts for sin, cos, tan : [Attachment 437797] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nikos Mouchtaris
<nmouchtaris at apple.com>'s request for review:
Bug 230129: Add wpts for sin,cos,tan
https://bugs.webkit.org/show_bug.cgi?id=230129

Attachment 437797: Patch

https://bugs.webkit.org/attachment.cgi?id=437797&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 437797
  --> https://bugs.webkit.org/attachment.cgi?id=437797
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437797&action=review

r+ on the tests

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:648
> +	   if (calcOperationNode.isTrigNode() && depth)

This should be done separately.

>
LayoutTests/imported/w3c/web-platform-tests/css/css-values/sin-cos-tan-computed
.html:5
> +<link rel="author" title="Nikos Mouchtaris"
href="mailto:nmouchtaris at apple.com">

You don't have to give your email. I think we can just say "Apple Inc" as the
author.

>
LayoutTests/imported/w3c/web-platform-tests/css/css-values/sin-cos-tan-invalid.
html:5
> +<link rel="author" title="Xiaocheng Hu"
href="mailto:xiaochengh at chromium.org">

That's not you!