[webkit-reviews] review granted: [Bug 230104] [build.webkit.org] Only display filtered build logs : [Attachment 437752] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Aakash Jain <aakash_jain at apple.com>'s
request for review:
Bug 230104: [build.webkit.org] Only display filtered build logs
https://bugs.webkit.org/show_bug.cgi?id=230104

Attachment 437752: Patch

https://bugs.webkit.org/attachment.cgi?id=437752&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 437752
  --> https://bugs.webkit.org/attachment.cgi?id=437752
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437752&action=review

> Tools/CISupport/build-webkit-org/steps_unittest.py:423
> +		   command='perl ./Tools/Scripts/build-webkit --release
--prefix=/app/webkit/WebKitBuild/Release/install --gtk |
Tools/Scripts/filter-build-webkit',

Why are we using a "./" prefix for build-webkit but not for
filter-build-webkit? I think it should be used in both cases, since we don’t
want $PATH involved.