[webkit-reviews] review granted: [Bug 229251] [WebAudio/WebM] Incorrect number of frames returned if decoding frame rate doesn't match original : [Attachment 437617] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 229251: [WebAudio/WebM] Incorrect number of frames returned if decoding
frame rate doesn't match original
https://bugs.webkit.org/show_bug.cgi?id=229251

Attachment 437617: Patch

https://bugs.webkit.org/attachment.cgi?id=437617&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 437617
  --> https://bugs.webkit.org/attachment.cgi?id=437617
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437617&action=review

> Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp:339
> +    uint32_t leadingTrim =
m_webmData->m_track->codecDelay().value_or(MediaTime()).toDouble() *
outFormat.mSampleRate;

`MediaTime::zeroTime()` should be cheaper than `MediaTime()`

> Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp:341
> +    uint32_t trailingTrim =
(m_webmData->m_track->codecDelay().value_or(MediaTime()) +
m_webmData->m_track->discardPadding().value_or(MediaTime())).toDouble() *
outFormat.mSampleRate - leadingTrim + 0.5;

Ditto