[webkit-reviews] review granted: [Bug 230024] [macOS] -[WKFullScreenWindowController exitFullScreenImmediately] does not exit fullscreen immediately : [Attachment 437566] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 8 10:39:06 PDT 2021
Jer Noble <jer.noble at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 230024: [macOS] -[WKFullScreenWindowController exitFullScreenImmediately]
does not exit fullscreen immediately
https://bugs.webkit.org/show_bug.cgi?id=230024
Attachment 437566: Patch
https://bugs.webkit.org/attachment.cgi?id=437566&action=review
--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 437566
--> https://bugs.webkit.org/attachment.cgi?id=437566
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=437566&action=review
LGTM. I'd take this opportunity to rename -finishedExitFullScreenAnimation: to
something that says what the parameter is, like
-finishedExitFullScreenAnimationAndExitImmediately:(BOOL)immediately.
> Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:572
> + if (immediately)
> + [self completeFinishExitFullScreenAnimationAfterRepaint];
> + else {
> + _page->forceRepaint([weakSelf =
WeakObjCPtr<WKFullScreenWindowController>(self)] {
> + [weakSelf completeFinishExitFullScreenAnimationAfterRepaint];
> + });
> + }
Nit: I'd have an early return here, rather than an else.
More information about the webkit-reviews
mailing list