[webkit-reviews] review granted: [Bug 229927] [Win] TestWebKitAPI.WebKit.DidNotHandleKeyDown is failing : [Attachment 437449] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 18:20:03 PDT 2021


Don Olmstead <don.olmstead at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 229927: [Win] TestWebKitAPI.WebKit.DidNotHandleKeyDown is failing
https://bugs.webkit.org/show_bug.cgi?id=229927

Attachment 437449: Patch

https://bugs.webkit.org/attachment.cgi?id=437449&action=review




--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 437449
  --> https://bugs.webkit.org/attachment.cgi?id=437449
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437449&action=review

r=me

I think this will break the PlayStation without the implementation being there
as well.

> Tools/TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:29
> +#if !PLATFORM(GTK) && !PLATFORM(WPE)

This should probably be

#if PLATFORM(COCOA) || PLATFORM(WIN)

> Tools/TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:72
> +#endif // !PLATFORM(GTK) && !PLATFORM(WPE)

Same


More information about the webkit-reviews mailing list