[webkit-reviews] review denied: [Bug 229784] KeyboardEvent should setDefaultHandled if EventHandler::startKeyboardScrolling returns true : [Attachment 437385] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 229784: KeyboardEvent should setDefaultHandled if
EventHandler::startKeyboardScrolling returns true
https://bugs.webkit.org/show_bug.cgi?id=229784

Attachment 437385: Patch

https://bugs.webkit.org/attachment.cgi?id=437385&action=review




--- Comment #8 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 437385
  --> https://bugs.webkit.org/attachment.cgi?id=437385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437385&action=review

>> LayoutTests/fast/scrolling/keyboard-scrolling-last-timestamp.html:19
>> +		await UIHelper.delayFor(500);
> 
> Is there any way to write this test without a 500ms pause? We generally try
to avoid this at the scale of 60k tests :)

Good point. UIHelper.waitForTargetScrollAnimationToSettle seems the one I want.