[webkit-reviews] review granted: [Bug 230015] Replace PrivateClickMeasurementNetworkLoader::start with an implementation that doesn't need NetworkSession : [Attachment 437546] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted	review:
Bug 230015: Replace PrivateClickMeasurementNetworkLoader::start with an
implementation that doesn't need NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=230015

Attachment 437546: Patch

https://bugs.webkit.org/attachment.cgi?id=437546&action=review




--- Comment #5 from John Wilander <wilander at apple.com> ---
Comment on attachment 437546
  --> https://bugs.webkit.org/attachment.cgi?id=437546
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437546&action=review

We should check that we're not leaving behind an ephemeral, stateless session
that is no longer used. I believe we use it for more things but we should make
sure.

See inline questions. r=me as long as EWS is happy.

> Source/WebKit/ChangeLog:8
> +	   This is needed to run this code in a process that doesn't have
NetworkSession, which is a class tied closely to WKWebsiteDataStore.

With this change, do we still have guarantees that PCM will not be enabled in
ephemeral sessions?

> Source/WebKit/ChangeLog:11
> +	   2. Does not allow redirects.

Did we have this configuration before? I'm for it until we are proven otherwise
but I want to keep track of any functional changes.

>
Source/WebKit/NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurem
entNetworkLoaderCocoa.mm:88
> +	   configuration._shouldSkipPreferredClientCertificateLookup = YES;

What does this imply?