[webkit-reviews] review denied: [Bug 230016] Remove responsiveness timer in NetworkProcessProxy::getNetworkProcessConnection : [Attachment 437543] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 7 13:06:15 PDT 2021
Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 230016: Remove responsiveness timer in
NetworkProcessProxy::getNetworkProcessConnection
https://bugs.webkit.org/show_bug.cgi?id=230016
Attachment 437543: Patch
https://bugs.webkit.org/attachment.cgi?id=437543&action=review
--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 437543
--> https://bugs.webkit.org/attachment.cgi?id=437543
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=437543&action=review
> Source/WebKit/ChangeLog:9
> + responsiveness timer in
NetworkProcessProxy::getNetworkProcessConnection, blocked netowrk process will
be killed
typo: netowrk
> Source/WebKit/ChangeLog:10
> + and a new network process will be launched for getting connection.
However, the new network process may stuck
"may get stuck"
> Source/WebKit/ChangeLog:11
> + in initializeNetworkProcess too. In this case, web process will
crash for not able to get network process
"for not being able"
> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:-253
> - startResponsivenessTimer(UseLazyStop::No);
What if we have a hung network process? Now we won't recover.
This patch is a revert of https://bugs.webkit.org/show_bug.cgi?id=226994
without trying to resolve the problem
https://bugs.webkit.org/show_bug.cgi?id=226994 was addressing.
More information about the webkit-reviews
mailing list