[webkit-reviews] review granted: [Bug 230006] [build.webkit.org][ews-build.webkit.org] Only try to download from S3 on the production server : [Attachment 437525] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 230006: [build.webkit.org][ews-build.webkit.org] Only try to download from
S3 on the production server
https://bugs.webkit.org/show_bug.cgi?id=230006

Attachment 437525: Patch

https://bugs.webkit.org/attachment.cgi?id=437525&action=review




--- Comment #4 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 437525
  --> https://bugs.webkit.org/attachment.cgi?id=437525
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437525&action=review

> Tools/CISupport/build-webkit-org/steps.py:412
> +	   self.results = SKIPPED

Ditto. This line isn't needed.

> Tools/CISupport/ews-build/steps.py:2806
> +	   self.results = SKIPPED

This line isn't needed. Better to remove it. I tested in
https://ews-build.webkit-uat.org/#/builders/34/builds/41512 that it works
without this line.