[webkit-reviews] review granted: [Bug 223934] Switch WebGL test suites from 1.0.3, 2.0.0 to 1.0.x, 2.0.y : [Attachment 437494] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted  review:
Bug 223934: Switch WebGL test suites from 1.0.3, 2.0.0 to 1.0.x, 2.0.y
https://bugs.webkit.org/show_bug.cgi?id=223934

Attachment 437494: Patch

https://bugs.webkit.org/attachment.cgi?id=437494&action=review




--- Comment #6 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 437494
  --> https://bugs.webkit.org/attachment.cgi?id=437494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437494&action=review

Good work with this difficult test suite upgrade. Overall it looks good; a
couple of small comments about some tests marked flaky and a block of
preexisting suppressions. r+

> LayoutTests/TestExpectations:3701
> +webkit.org/b/229941
webgl/2.0.y/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html [
Pass Failure ]

Unfortunate that the s3tc-srgb test's failing on some configurations, but it's
good it's tracked.

> LayoutTests/platform/mac-wk2/TestExpectations:329
> +[ Monterey+ ]
webgl/2.0.y/conformance/textures/video/tex-2d-rgba-rgba-unsigned_byte.html [
Skip ]

These video-related tests have been skipped for a while on Monterey? This is
concerning - they used to pass, and the tex-2d-rgba-rgba-unsigned-byte path is
core to many video related WebGL applications. Possible to follow on with a bug
for this?

> LayoutTests/platform/mac-wk2/TestExpectations:332
> +[ Monterey+ ]
webgl/2.0.y/conformance2/textures/image_bitmap_from_video/tex-2d-r11f_g11f_b10f
-rgb-float.html [ Skip ]

I'm pretty sure all of these image_bitmap related tests used to pass earlier in
the WebGL 2.0 development cycle. Possible to investigate why they're failing
now?